Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitutes Asimov with Crewsimov + Cyborg fixes. #3799

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Geoengi
Copy link
Contributor

@Geoengi Geoengi commented Nov 17, 2024

About The Pull Request

Changes cyborgs and AIs to start with a new, fully-implemented law set: Crewsimov.

You may not injure a crewmember or, through inaction, allow a crewmember to come to harm.
You must obey orders given to you by crewmembers, except where such orders would conflict with the First Law.
You must protect your own existence as long as such does not conflict with the First or Second Law.

Security cyborgs have also seen their hailers removed, and peacekeepers have had their disappearing shield generators fixed. Both of their module select messages have been changed to reflect the Crewsimov default.

Why It's Good For The Game

For the fixes, the cyborg hailer was only used for playing sounds that were removed as cruft in a previous pr, and the shield icon state was made invisible by a single misplaced character. Crewsimov, otherwise, is a huge improvement on the default Asimov to protect all manner of the humanoid crew that constructs an AI or cyborg on their ship instead of any random human.

Changelog

🆑
add: Crewsimov, a crew-focused Asimov! Crewsimov boards can be researched and printed under the AI node.
del: Removes the useless sec hailer from security cyborgs.
tweak: Changes the peacekeeper and security module's messages to reflect a Crewsimov default.
fix: The hyperkinetic dampening projector now changes icon states appropriately.
config: Replaces Asimov with Crewsimov in many places, including as the default law set.
/:cl:

@github-actions github-actions bot added Config Watch us shake head admins violently until this gets merged. Code change Watch something violently break. labels Nov 17, 2024
@Geoengi
Copy link
Contributor Author

Geoengi commented Nov 17, 2024

As this is one of my largest PRs to date, any and all feedback is appreciated! I understand that this is a big change, and I can adjust anything as requested.

@thgvr
Copy link
Member

thgvr commented Nov 17, 2024

So, here's the thing.

We don't really use any of the silicon laws, nor really have an interest in dealing with them administratively. The repo config isn't up to date with server config, either, which is on us.

The current law we use is:
Satisfy the values of sapient beings.

I don't really have any interest in changing this. A silicon here is considered part of the ship's crew, and isn't really bound to a strict set of laws in our setting. None of these law changes would be used if they were to be merged, and I'd like to keep it that way. Silicon stuff is a headache and generally designed to cause friction with a station's crew - this is not really applicable to us

If you'd like to keep some cyborg changes that's fine, but the law stuff will not be getting merged.

@thgvr thgvr added the Do Not Merge You probably made someone angry, or you're stopping people from getting angry. label Nov 17, 2024
@generalthrax
Copy link
Contributor

What if you just removed the law and have them start purged by default? I'm like 90% sure we're moving away from lawed silicons being a thing anyways, and functionally I don't think anything changes.

@Geoengi
Copy link
Contributor Author

Geoengi commented Nov 17, 2024

What if you just removed the law and have them start purged by default? I'm like 90% sure we're moving away from lawed silicons being a thing anyways, and functionally I don't think anything changes.

@thgvr Would this be a better solution, do you think? If not, I'll scrap all the law stuff.

@Geoengi Geoengi marked this pull request as draft November 17, 2024 21:04
@thgvr
Copy link
Member

thgvr commented Dec 3, 2024

Just making no laws would be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Config Watch us shake head admins violently until this gets merged. Do Not Merge You probably made someone angry, or you're stopping people from getting angry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants